Bugfix/inline editing provisional drafts #15962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replication steps:
Solution:
When getting the edited entries by their IDs, get the provisional drafts, too. When composing an array of errors to be passed back to JS, index the errors by canonical ID (as that’s what’s used in the
data-id
attribute for element rows).Note: when inline editing a provisional draft, the changes will be applied to the provisional draft, not the canonical element.
Related issues
n/a (found by Luke)