Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds min/max sale price querying/filtering to the bike page #150

Open
wants to merge 9 commits into
base: stable
Choose a base branch
from
Open

Adds min/max sale price querying/filtering to the bike page #150

wants to merge 9 commits into from

Conversation

nfourtythree
Copy link
Collaborator

No description provided.

@nfourtythree nfourtythree self-assigned this Sep 14, 2024
timkelty
timkelty requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@timkelty timkelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-09-16 at 13 17 08@2x

"clear filters" doesn't appear to work with the new price field. I tried to add it quickly, but failed. Up to you if you think it matters or not, but I noticed it so passing it on.

modules/Module.php Show resolved Hide resolved
@nfourtythree
Copy link
Collaborator Author

CleanShot 2024-09-16 at 13 17 08@2x

"clear filters" doesn't appear to work with the new price field. I tried to add it quickly, but failed. Up to you if you think it matters or not, but I noticed it so passing it on.

Have pushed a fix for this, everything should be ready to go if you are happy to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkelty timkelty timkelty requested changes

Assignees

@nfourtythree nfourtythree

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfourtythree @timkelty