Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional unit tests for new code #45

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Additional unit tests for new code #45

merged 2 commits into from
Jul 10, 2024

Conversation

craigthomas
Copy link
Owner

This PR adds additional unit tests for lines of code that were missing coverage. This PR closes #42

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (b802ca0) to head (904cea4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   92.87%   94.72%   +1.85%     
==========================================
  Files           4        4              
  Lines         660      664       +4     
==========================================
+ Hits          613      629      +16     
+ Misses         47       35      -12     
Files Coverage Δ
chip8/cpu.py 98.96% <100.00%> (+2.51%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b802ca0...904cea4. Read the comment docs.

@craigthomas craigthomas merged commit cc34898 into main Jul 10, 2024
3 checks passed
@craigthomas craigthomas deleted the pre-v2-unit-tests branch July 22, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for missing CPU routines
1 participant