feat: Publish using rust-version toolchain
#381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
commented
Jan 4, 2022
| | `publish` | `--no-publish` | bool | Don't do cargo publish right now, see [manifest `publish` field](https://doc.rust-lang.org/cargo/reference/manifest.html#the-publish--field-optional) to permanently disable publish. | | ||
| | `tag` | `--no-tag` | bool | Don't do git tag | | ||
| | `publish` | `--no-publish` | bool | Don't do cargo publish right now, see [manifest `publish` field](https://doc.rust-lang.org/cargo/reference/manifest.html#the-publish--field-optional) to permanently disable publish. | | ||
| | `rust-version` | | string | Toolchain version to use for publishing (specify `"manifest"` to use [Cargo.toml's `rust-version`](https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field) | |
There was a problem hiding this comment.
Should we be concerned there isn't a way to turn this off?
I'm tempted to overlay this with a bool so you can just enable/disable it. Just lazy about writing the serde logic for it.
This is a last ditch effort to catch MSRV issues. Fixes crate-ci#380
epage
commented
Jan 4, 2022
Comment on lines
+96
to
+102
| if let Some(toolchain_version) = toolchain_version { | ||
| formatted_toolchain_version = format!("+{}", toolchain_version); | ||
| command = vec!["cargo", &formatted_toolchain_version]; | ||
| } else { | ||
| bin = cargo(); | ||
| command = vec![&bin]; | ||
| } |
There was a problem hiding this comment.
Should we be concerned that we are ignoring CARGO when using the rust-version?
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a last ditch effort to catch MSRV issues.
Fixes #380