Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support drop-in replacements for cargo #12

Closed
epage opened this issue Sep 10, 2018 · 4 comments
Closed

Support drop-in replacements for cargo #12

epage opened this issue Sep 10, 2018 · 4 comments
Labels
enhancement Improve the expected

Comments

@epage
Copy link
Contributor

epage commented Sep 10, 2018

Like xargo, see roblabla/cargo-travis#34 (comment)

@epage epage added the enhancement Improve the expected label Sep 10, 2018
@epage
Copy link
Contributor Author

epage commented Sep 10, 2018

Options

  • Extra constructor for Cargo
  • Environment variable
    • Seems like this should more so be a policy for clients to define?
    • But a consistent policy would be nice

@roblabla
Copy link

cargo_metadata uses the CARGO environment variable. https://github.com/oli-obk/cargo_metadata/blob/master/src/lib.rs#L302

@roblabla
Copy link

Note that while this works fine for overriding cargo in the cargo metadata case (it allows setting the path to the cargo binary), it's not such a great solution for cases where you want to override cargo build so it instead runs cargo xbuild for instance. I'm not sure how to best handle this.

epage added a commit to epage/escargot that referenced this issue Sep 13, 2018
@epage
Copy link
Contributor Author

epage commented Sep 13, 2018

it's not such a great solution for cases where you want to override cargo build so it instead runs cargo xbuild for instance. I'm not sure how to best handle this.

I guess that could be a special environment variable for escargot? The only other option is a custom cargo wrapper that maps build to xbuild.

@epage epage closed this as completed in #15 Sep 13, 2018
@epage epage mentioned this issue Sep 13, 2018
epage added a commit to epage/escargot that referenced this issue Apr 26, 2024
…on-5.x

chore(deps): update actions/setup-python action to v5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants