Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown message build-finished #40

Closed
Nemo157 opened this issue Aug 13, 2020 · 2 comments
Closed

Unknown message build-finished #40

Nemo157 opened this issue Aug 13, 2020 · 2 comments

Comments

@Nemo157
Copy link

Nemo157 commented Aug 13, 2020

Just noticed that I'm getting an unknown message with some recent version of Cargo:

Message("{\"reason\":\"build-finished\",\"success\":true}\n")
@Nemo157
Copy link
Author

Nemo157 commented Aug 13, 2020

Related change: rust-lang/cargo#8069

It seems like this should be used by escargot to know when to stop consuming messages, and might allow a setup where cargo run is actually used instead of emulated.

epage pushed a commit to epage/escargot that referenced this issue Jan 31, 2021
feat(build): Support build-finished message
4dbb90c 
Fixes crate-ci#40
@epage
Copy link
Contributor

epage commented Jan 31, 2021

Sorry, somehow I lost track of this. I'm adding support for all missing fields. Probably not going to have time for taking advantage of build-finished though.

@epage epage closed this as completed in 598be46 Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @Nemo157