You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey 👋! I'm using a downstream package git-cliff which produces incorrect output when parsing such commit messages:
fix(example): fix keepachangelog config example
Fixes: #123, #124, #125
and the author of git-cliff helpfully redirected my question to here since the parsing apparently happens via git-conventional. Here's the full context orhun/git-cliff#130.
I carefully went through the Conventional Commits specification here and also here and I'm under the impression that Fixes: #123, #124, #125 should be a valid trailer with a token "Fixes" and a value "#123, #124, #125".
Hey 👋! I'm using a downstream package
git-cliff
which produces incorrect output when parsing such commit messages:and the author of git-cliff helpfully redirected my question to here since the parsing apparently happens via
git-conventional
. Here's the full context orhun/git-cliff#130.I carefully went through the Conventional Commits specification here and also here and I'm under the impression that
Fixes: #123, #124, #125
should be a valid trailer with a token "Fixes" and a value "#123, #124, #125".As a sanity check,
@conventional-commits/parser
does exactly that https://runkit.com/embed/212h966ic1s1So does git's built-in parser:
Any chance that
git-conventional
just assumes the trailer value ends on whitespace?The text was updated successfully, but these errors were encountered: