-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dockerfile for #427. #431
Conversation
|
||
FROM debian:buster-slim | ||
COPY --from=builder /usr/local/cargo/bin/typos /usr/local/bin/typos | ||
CMD ["typos"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having it as command instead of entry point makes it more overriable, but less obvious
docker run crate-ci/typos
would run typos
docker run crate-ci/typos bash
would run bash
docker run crate-ci/typos typos --with --args
would run typos
i can make a smarter entrypoint that handles bash vs not bash though.
Does cargo install build the right one? I'll have to run again when I'm at a computer to confirm its the release version. Otherwise I can probably build release and copy from target instead |
It looks like |
could use https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md to build and publish to ghcr.io |
Thanks! |
Builds all the binaries on demand, then creates a new image with just the binary.
Easy to do tagged releases or multi arch builds, etc.