Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more python file extensions #985

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add more python file extensions #985

merged 2 commits into from
Apr 9, 2024

Conversation

augustelalande
Copy link
Contributor

Add more python file extensions. Namely .ipynb for jupyter notebook files, and .pyi for stub files.

@augustelalande
Copy link
Contributor Author

Just noticed jupyter notebook is a seperate entry. I also didn't realise jupyter supports more languages than just python (although I think python is still the most common). Anyway it would be nice so support the python ignores in jupyter, although I'm not sure how you guys want to structure that.

@epage
Copy link
Collaborator

epage commented Apr 9, 2024

Let's split jupyter out to an issue to discuss how that should be handled and then we can move forward with pyi immediately

@augustelalande
Copy link
Contributor Author

Sounds like a plan

@augustelalande
Copy link
Contributor Author

I removed the ipynb extension, but after giving more thought I don't feel strongly that the python specific dictionary should be used with the jupyter notebooks. In short, I think false negatives are worse than false positives.

@epage epage merged commit 859859a into crate-ci:master Apr 9, 2024
13 of 14 checks passed
@augustelalande augustelalande deleted the add-more-python-extensions branch April 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants