bump pyO3 to 0.22.6 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causes installation to fail (rightly so) on free-threaded Python, instead of installing a version that segfaults. This was the intended behavior of pyO3 starting with 0.22.2
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causes installation to fail (rightly so) on unsupported free-threaded Python, instead of installing a version that segfaults on import.
This was the intended behavior of pyO3 starting with 0.22.2, but the backport of the check wasn't quite right until 0.22.6.
If build is allowed to proceed by setting
UNSAFE_PYO3_BUILD_FREE_THREADED=1, it still segfaults atimport rpdswith 0.22.6, so it is good that installation does not proceed without this opt-in.upstream issue: PyO3/pyo3#4682