-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose store.type
table parameter and node.store.allow_mmap
setting.
#9125
Conversation
I think we could directly include related fixes/changes like elastic/elasticsearch#38940 inside the PR as well. |
Should we also document this new type and add a release notes entry? |
@seut backported elastic/elasticsearch#38940 and a couple of refactoring commits. If it is ok, I'd like to get this PR merged and follow up with renaming the |
Backport of elastic/elasticsearch#36668 This commit introduces a new store type hybridfs that is a hybrid between mmapfs and niofs.
store.type
table parameter and node.store.allow_mmap
setting.
76d1324
to
b7fe596
Compare
|
||
public static final Setting<String> INDEX_STORE_TYPE_SETTING = | ||
new Setting<>("index.store.type", "", Function.identity(), Property.IndexScope, Property.NodeScope); | ||
new Setting<>("index.store.type", "fs", Function.identity(), Property.IndexScope, Property.NodeScope); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set the fs
value explicitly as the setting's default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, I've added just one comment about the fs
documentation.
Also I think we should add a CHANGES entry about that we've changed the default FS to hybridfs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Lgtm
Summary of the changes / Why this improves CrateDB
See commits.
Checklist
CHANGES.txt
CHANGES.txt
(E.g. AdminUI)