Fix IsInRange and added unit tests. (AvaloniaUI#15079)

crazeteam · Mar 23, 2024 · da6b11e · da6b11e
1 parent bad2e8d
commit da6b11e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/Avalonia.Base/Media/UnicodeRange.cs b/src/Avalonia.Base/Media/UnicodeRange.cs
@@ -131,7 +131,7 @@ public UnicodeRangeSegment(int start, int end)
         /// </returns>
         public bool IsInRange(int value)
         {
-            return value - Start <= End - Start;
+            return Start <= value && value <= End;
         }
 
         /// <summary>

diff --git a/tests/Avalonia.Base.UnitTests/Media/UnicodeRangeSegmentTests.cs b/tests/Avalonia.Base.UnitTests/Media/UnicodeRangeSegmentTests.cs
@@ -18,5 +18,28 @@ public void Should_Parse(string s, int expectedStart, int expectedEnd)
 
             Assert.Equal(expectedEnd, segment.End);
         }
+
+        [InlineData(0)]
+        [InlineData(19)]
+        [InlineData(26)]
+        [InlineData(100)]
+        [Theory]
+        public void InRange_Should_Return_False_For_Values_Outside_Range(int value)
+        {
+            var segment = new UnicodeRangeSegment(20, 25);
+
+            Assert.Equal(false, segment.IsInRange(value));
+        }
+
+        [InlineData(20)]
+        [InlineData(21)]
+        [InlineData(22)]
+        [Theory]
+        public void InRange_Should_Return_True_For_Values_Within_Range(int value)
+        {
+            var segment = new UnicodeRangeSegment(20, 22);
+
+            Assert.Equal(true, segment.IsInRange(value));
+        }
     }
 }