Add DB_HOST format support fix 147 #152
Open
+55
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abase when postgres database not exist.
|
Temporary fix nextcloud/server#38750 |
|
Hello @crazy-max , do you have time to check this pull request, I rewrote the logic of setting up the database and can match the logic of nextcloud. |
crazy-max
reviewed
Nov 7, 2024
Comment on lines
+167
to
+172
| if ! bash -c ${dbexist_cmd}; then | ||
| createdb -h ${dbhost} -p ${dbport} -U ${DB_USER} -E UTF8 ${DB_NAME} # nextcloud bug under 28, https://github.com/nextcloud/server/pull/38750 | ||
| if ! bash -c ${dbexist_cmd}; then | ||
| echo >&2 "ERROR: Failed to create database ${DB_NAME} on $DB_HOST" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
With nextcloud/server#38750 merged, don't think we need this workaround anymore.
There was a problem hiding this comment.
That just one of the problems.
This container still don't support the DB_HOST set to domain/ip:port.
I didn't find the way to modify the port of the database being connected to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DB_HOST
domain/ipordomain/ip:portsupport;Create database when postgres database does not exist.