Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GIT_DOMAIN env variable to override default domain #133

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Added GIT_DOMAIN env variable to override default domain #133

merged 1 commit into from
Mar 15, 2021

Conversation

lkrzyzanek
Copy link
Contributor

fixes #132

@lkrzyzanek lkrzyzanek requested a review from crazy-max as a code owner February 4, 2021 11:30
@stale
Copy link

stale bot commented Mar 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 💀 stale label Mar 6, 2021
crazy-max
crazy-max requested changes Mar 13, 2021
View reviewed changes
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkrzyzanek Thanks for your contrib. Please read the contribution notes (missing yarn run pre-checkin).

@lkrzyzanek
Copy link
Contributor Author

Thanks for review. I run yarn run pre-checkin and commit changes again.

crazy-max
crazy-max approved these changes Mar 15, 2021
View reviewed changes
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your contrib. I think I will do a small change to use action input instead of an env var. Keep you in touch in a follow-up PR.

@lkrzyzanek
Copy link
Contributor Author

Cool. Thanks a lot!

@crazy-max crazy-max merged commit 111278e into crazy-max:dev Mar 15, 2021
This was referenced Mar 16, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 16, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
bors bot referenced this pull request in hermit-os/kernel Mar 22, 2021
@bors @dependabot
Merge #175
15b6009 
175: Bump crazy-max/ghaction-github-pages from v2.2.0 to v2.3.0 r=stlankes a=dependabot[bot]

Bumps [crazy-max/ghaction-github-pages](https://github.com/crazy-max/ghaction-github-pages) from v2.2.0 to v2.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/crazy-max/ghaction-github-pages/releases">crazy-max/ghaction-github-pages's releases</a>.</em></p>
<blockquote>
<h2>v2.3.0</h2>
<ul>
<li>Bring back copySync (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/135">#135</a>)</li>
<li>Container based developer flow (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/134">#134</a>)</li>
<li>Add <code>domain</code> input (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/133">#133</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/crazy-max/ghaction-github-pages/blob/dev/CHANGELOG.md">crazy-max/ghaction-github-pages's changelog</a>.</em></p>
<blockquote>
<h2>2.3.0 (2021/03/16)</h2>
<ul>
<li>Bring back copySync (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/135">#135</a>)</li>
<li>Container based developer flow (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/134">#134</a>)</li>
<li>Add <code>domain</code> input (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/133">#133</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/b8f8d291c97fe0edd9fb4ee73018163593418e8f"><code>b8f8d29</code></a> Update CHANGELOG</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/e64e818e8352948fb230e0e996ba4d26c7554299"><code>e64e818</code></a> Bring back copySync (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/135">#135</a>)</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/c6b59a001850cb738621f9de46ee1d81388d5a25"><code>c6b59a0</code></a> Switch to domain input for GIT_DOMAIN</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/85c97ee40b932b43e2a795442503e487c47dfd6e"><code>85c97ee</code></a> Container based developer flow (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/134">#134</a>)</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/ad72f0704d64ef6546d1265d6668f2faf285d62e"><code>ad72f07</code></a> Update labels</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/111278e49fd177b344eacec7dc61ee6547ec18cd"><code>111278e</code></a> Added GIT_DOMAIN env variable to override default domain (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/133">#133</a>)</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/2e4f8c2395da12757455b259f9789e5c74778d1c"><code>2e4f8c2</code></a> 2021</li>
<li>See full diff in <a href="https://github.com/crazy-max/ghaction-github-pages/compare/v2.2.0...b8f8d291c97fe0edd9fb4ee73018163593418e8f">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
simonschoening referenced this pull request in simonschoening/libhermit-rs Aug 26, 2021
@bors @dependabot
Merge hermit-os#175
42a6a0e 
175: Bump crazy-max/ghaction-github-pages from v2.2.0 to v2.3.0 r=stlankes a=dependabot[bot]

Bumps [crazy-max/ghaction-github-pages](https://github.com/crazy-max/ghaction-github-pages) from v2.2.0 to v2.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/crazy-max/ghaction-github-pages/releases">crazy-max/ghaction-github-pages's releases</a>.</em></p>
<blockquote>
<h2>v2.3.0</h2>
<ul>
<li>Bring back copySync (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/135">#135</a>)</li>
<li>Container based developer flow (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/134">#134</a>)</li>
<li>Add <code>domain</code> input (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/133">#133</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/crazy-max/ghaction-github-pages/blob/dev/CHANGELOG.md">crazy-max/ghaction-github-pages's changelog</a>.</em></p>
<blockquote>
<h2>2.3.0 (2021/03/16)</h2>
<ul>
<li>Bring back copySync (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/135">#135</a>)</li>
<li>Container based developer flow (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/134">#134</a>)</li>
<li>Add <code>domain</code> input (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/133">#133</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/b8f8d291c97fe0edd9fb4ee73018163593418e8f"><code>b8f8d29</code></a> Update CHANGELOG</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/e64e818e8352948fb230e0e996ba4d26c7554299"><code>e64e818</code></a> Bring back copySync (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/135">#135</a>)</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/c6b59a001850cb738621f9de46ee1d81388d5a25"><code>c6b59a0</code></a> Switch to domain input for GIT_DOMAIN</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/85c97ee40b932b43e2a795442503e487c47dfd6e"><code>85c97ee</code></a> Container based developer flow (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/134">#134</a>)</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/ad72f0704d64ef6546d1265d6668f2faf285d62e"><code>ad72f07</code></a> Update labels</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/111278e49fd177b344eacec7dc61ee6547ec18cd"><code>111278e</code></a> Added GIT_DOMAIN env variable to override default domain (<a href="https://github.com/crazy-max/ghaction-github-pages/issues/133">#133</a>)</li>
<li><a href="https://github.com/crazy-max/ghaction-github-pages/commit/2e4f8c2395da12757455b259f9789e5c74778d1c"><code>2e4f8c2</code></a> 2021</li>
<li>See full diff in <a href="https://github.com/crazy-max/ghaction-github-pages/compare/v2.2.0...b8f8d291c97fe0edd9fb4ee73018163593418e8f">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow override git domain
2 participants
@lkrzyzanek @crazy-max