Use GPG key name/email as default values #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 3 3
Lines 114 114
Branches 26 26
=======================================
Hits 92 92
Misses 12 12
Partials 10 10 Continue to review full report at Codecov.
|
This way `ci` workflow can be completed from forks
crazy-max
approved these changes
May 12, 2020
There was a problem hiding this comment.
@alejandrohdezma Overall that's LGTM, thanks! I will create a v2 of this action and also review the integration of the test key and its passphrase (will play with outputs instead).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for this action! It's really awesome! ❤️
What has been done in this PR?
❗ This PR includes breaking changes that will provoke unexpected failures or behaviour on current users, and therefore I would suggest to release them (in case they're approved) as a new
v2version.Breaking changes
New features
Why this change?
Using the GPG key name & email as defualt values would simplify a lot doing key-rotation when using this action. Only the secret will need to be updated then, since commiter's name & email will be taken from the GPG key data.