Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for 0.3.1 changes #93

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Update README for 0.3.1 changes #93

merged 2 commits into from
Sep 18, 2017

Conversation

iRoachie
Copy link
Contributor

0.3.1 changes the package identifier to org.devio in commit ed6df50

This PR just updates in the installation instructions in the README

@mgtitimoli
Copy link

Great @iRoachie I was about to do the same when I saw your PR.

Don't you mind to add an entry of how to use with CocoaPods?

@iRoachie
Copy link
Contributor Author

@mgtitimoli I'm not actually sure how cocoapods works (js developer). Maybe you could do it in another PR

@mgtitimoli
Copy link

JS dev here too 🙂.

Basically the changes I'm saying can be split into two

pod 'react-native-splash-screen', path: '../node_modules/react-native-splash-screen'

  1. Move the content under Manual installation > IOS to Manual installation > IOS > With XCode
  2. Add a new section Manual installation > IOS > With CocoaPods and place the following within:
1. Add the plugin dependency to your Podfile:
`pod 'react-native-splash-screen', path: '../node_modules/react-native-splash-screen'`
2. Run pod install

As a side note, I recommend you to try CocoaPods, I found it cleaner than placing everything in the xcode project file.

@iRoachie
Copy link
Contributor Author

@mgtitimoli Best to make another PR as it isn't in line with the 0.3.1 release

@crazycodeboy crazycodeboy merged commit f792147 into crazycodeboy:master Sep 18, 2017
@iRoachie iRoachie deleted the readme branch September 18, 2017 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants