Fix slice bounds out of range error on remove host entries #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkumar
approved these changes
Dec 14, 2023
| for hostIdx, hostname := range line.Hostnames { | ||
| if _, ok := hostEntries[hostname]; ok { | ||
| h.removeHostFromLine(line, hostIdx, i) | ||
| for _, hostToRemove := range hosts { |
| @@ -234,6 +234,18 @@ func TestRemoveOnOldHostFile(t *testing.T) { | |||
| assert.Equal(t, hostsTemplate, string(content)) | |||
| } | |||
|
|
|||
| func TestDeleteSliceBoundErrorOnRemove(t *testing.T) { | |||
|
Details about what was causing the bug and how it was fixed is always useful to have in a commit log, for better review, for easier understanding when we get back to this code, ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deleting host entries:
panic: runtime error: slice bounds out of range [4:3]The problem was in iterating over array which we modify(remove items from it)