Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display openshift version when starting VM #498

Closed
cfergeau opened this issue Aug 28, 2019 · 1 comment
Closed

Display openshift version when starting VM #498

cfergeau opened this issue Aug 28, 2019 · 1 comment

Comments

@cfergeau
Copy link
Contributor

Since we now know which bundle a VM is using, when starting up a VM, we can display which openshift version it's running. This should help clear up some potential confusion when the VM already exists.

Ideally, the openshift version a bundle was built from would be part of the bundle metadata. It's not there yet, so we extract it from the bundle name.
cfergeau added a commit to cfergeau/crc that referenced this issue Aug 28, 2019
@cfergeau
Issue crc-org#498: machine: Move 'Loading bundle' log
d9ebcee 
At the moment, when the bundle is not extracted, we display:
Loading Bundle...
Extracting Bundle...
which is a bit odd, if the bundle is not extracted yet, we cannot load
it. This commit prints the log only when the bundle was successfully
loaded, this way we'll either print "Loading bundle" or "Extracting
bundle" but not both.

crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Aug 28, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
f5e77a3 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.

This fixes crc-org#498
@gbraad
Copy link
Contributor

gbraad commented Aug 29, 2019

would be part of the bundle metadata

this is the only right place to get this from.
We can not rely on extracting this from the bundle name, as this can be modified by the user when used with -b (like eg. with Virtualbox).

cfergeau added a commit to cfergeau/crc that referenced this issue Aug 29, 2019
@cfergeau
Issue crc-org#498: machine: Move 'Loading bundle' log
5ffd315 
At the moment, when the bundle is not extracted, we display:
Loading Bundle...
Extracting Bundle...
which is a bit odd, if the bundle is not extracted yet, we cannot load
it. This commit prints the log only when the bundle was successfully
loaded, this way we'll either print "Loading bundle" or "Extracting
bundle" but not both.

crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Aug 30, 2019
@cfergeau
Issue crc-org#498: machine: Move 'Loading bundle' log
e98347b 
At the moment, when the bundle is not extracted, we display:
Loading Bundle...
Extracting Bundle...
which is a bit odd, if the bundle is not extracted yet, we cannot load
it. This commit prints the log only when the bundle was successfully
loaded, this way we'll either print "Loading bundle" or "Extracting
bundle" but not both.

crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 2, 2019
@cfergeau
Issue crc-org#498: machine: Move 'Loading bundle' log
fefa140 
At the moment, when the bundle is not extracted, we display:
Loading Bundle...
Extracting Bundle...
which is a bit odd, if the bundle is not extracted yet, we cannot load
it. This commit prints the log only when the bundle was successfully
loaded, this way we'll either print "Loading bundle" or "Extracting
bundle" but not both.

crc-org#498
praveenkumar pushed a commit that referenced this issue Sep 3, 2019
@cfergeau @praveenkumar
Issue #498: machine: Move 'Loading bundle' log
c199d5f 
At the moment, when the bundle is not extracted, we display:
Loading Bundle...
Extracting Bundle...
which is a bit odd, if the bundle is not extracted yet, we cannot load
it. This commit prints the log only when the bundle was successfully
loaded, this way we'll either print "Loading bundle" or "Extracting
bundle" but not both.

#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 3, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
4f094d9 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.
This requires a bundle with clusterInfo.openshiftVersion set in its
metadata. This should be the case for bundle releases newer than 4.1.11

This fixes crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 10, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
fe02964 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.
This requires a bundle with clusterInfo.openshiftVersion set in its
metadata. This should be the case for bundle releases newer than 4.1.11

This fixes crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 11, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
1b98471 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.
This requires a bundle with clusterInfo.openshiftVersion set in its
metadata. This should be the case for bundle releases newer than 4.1.11

This fixes crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 16, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
12542bd 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.
This requires a bundle with clusterInfo.openshiftVersion set in its
metadata. This should be the case for bundle releases newer than 4.1.11

This fixes crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 17, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
70f13a4 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.
This requires a bundle with clusterInfo.openshiftVersion set in its
metadata. This should be the case for bundle releases newer than 4.1.11

This fixes crc-org#498
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 18, 2019
@cfergeau
Issue crc-org#498: machine: Print openshift version when starting VM
30eaf8c 
It can clear up some confusion to be aware of what OpenShift version
our current crc VM is using.
This requires a bundle with clusterInfo.openshiftVersion set in its
metadata. This should be the case for bundle releases newer than 4.1.11

This fixes crc-org#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbraad @cfergeau