Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a message before asking for sudo password #570

Closed
anjannath opened this issue Sep 11, 2019 · 0 comments · Fixed by #571
Closed

Print a message before asking for sudo password #570

anjannath opened this issue Sep 11, 2019 · 0 comments · Fixed by #571

Comments

@anjannath
Copy link
Member

anjannath commented Sep 11, 2019

People have raised concerns as to why crc asks for root access during setup, this issue is to have crc print a reason before asking/using root access using sudo.

anjannath added a commit to anjannath/crc that referenced this issue Sep 11, 2019
anjannath added a commit to anjannath/crc that referenced this issue Sep 11, 2019
anjannath added a commit to anjannath/crc that referenced this issue Sep 11, 2019
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
…ng it

The RunWithPrivilege func now takes a string as its first argument
which is a 'reason' why root access is needed, this change is made
so that users are not  scared by seeing unreasonable prompt asking
them to enter their password by sudo.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
The ExecuteAsAdmin and ShellExecuteAsAdmin func now take a first
argument which isa string stating the reason why run as admin is
needed
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
…ng it

The RunWithPrivilege func now takes a string as its first argument
which is a 'reason' why root access is needed, this change is made
so that users are not  scared by seeing unreasonable prompt asking
them to enter their password by sudo.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
The ExecuteAsAdmin and ShellExecuteAsAdmin func now take a first
argument which isa string stating the reason why run as admin is
needed
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
After the previous two commits, the crc setup o/p  is slightly
changed, this commit updates the integration test to match the
new o/p.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
The ExecuteAsAdmin and ShellExecuteAsAdmin func now take a first
argument which isa string stating the reason why run as admin is
needed
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
After the previous two commits, the crc setup o/p  is slightly
changed, this commit updates the integration test to match the
new o/p.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
…ng it

The RunWithPrivilege func now takes a string as its first argument
which is a 'reason' why root access is needed, this change is made
so that users are not  scared by seeing unreasonable prompt asking
them to enter their password by sudo.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
The ExecuteAsAdmin and ShellExecuteAsAdmin func now take a first
argument which isa string stating the reason why run as admin is
needed
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
After the previous two commits, the crc setup o/p  is slightly
changed, this commit updates the integration test to match the
new o/p.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
After the previous two commits, the crc setup o/p  is slightly
changed, this commit updates the integration test to match the
new o/p.
anjannath added a commit to anjannath/crc that referenced this issue Sep 12, 2019
After the previous two commits, the crc setup o/p  is slightly
changed, this commit updates the integration test to match the
new o/p.
anjannath added a commit to anjannath/crc that referenced this issue Sep 13, 2019
…ng it

The RunWithPrivilege func now takes a string as its first argument
which is a 'reason' why root access is needed, this change is made
so that users are not  scared by seeing unreasonable prompt asking
them to enter their password by sudo.

In windows the ExecuteAsAdmin and ShellExecuteAsAdmin funcs take a
first argument which is the reason why it needs to run as admin.

Since the crc setup o/p  is slightly changed, the integration test
are updated to match the new o/p.
anjannath added a commit to anjannath/crc that referenced this issue Sep 13, 2019
…ng it

The RunWithPrivilege func now takes a string as its first argument
which is a 'reason' why root access is needed, this change is made
so that users are not  scared by seeing unreasonable prompt asking
them to enter their password by sudo.

In windows the ExecuteAsAdmin and ShellExecuteAsAdmin funcs take a
first argument which is the reason why it needs to run as admin.

Since the crc setup o/p  is slightly changed, the integration test
are updated to match the new o/p.
praveenkumar pushed a commit that referenced this issue Sep 13, 2019
The RunWithPrivilege func now takes a string as its first argument
which is a 'reason' why root access is needed, this change is made
so that users are not  scared by seeing unreasonable prompt asking
them to enter their password by sudo.

In windows the ExecuteAsAdmin and ShellExecuteAsAdmin funcs take a
first argument which is the reason why it needs to run as admin.

Since the crc setup o/p  is slightly changed, the integration test
are updated to match the new o/p.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant