Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force use of native SSH implementation #598

Closed
gbraad opened this issue Sep 16, 2019 · 0 comments · Fixed by #600
Closed

Force use of native SSH implementation #598

gbraad opened this issue Sep 16, 2019 · 0 comments · Fixed by #600
Assignees
@gbraad

Comments

@gbraad
Copy link
Contributor

gbraad commented Sep 16, 2019

We should force to use the golang native ssh implementation based on the platform.
@gbraad gbraad self-assigned this Sep 16, 2019
gbraad added a commit to gbraad-redhat/crc that referenced this issue Sep 17, 2019
@gbraad
Issue crc-org#598 Force native SSH implementation
a600472
@gbraad gbraad mentioned this issue Sep 17, 2019
Merged
gbraad added a commit to gbraad-redhat/crc that referenced this issue Sep 17, 2019
@gbraad
Issue crc-org#598 Force using golang's native SSH implementation
c0592a3 
This solves issues when using non-standard SSH clients, like wrappers
or incomplete implementation, as mostly found on Windows. Even though
Windows provides a usable client, often we find wrappers around plink
or Git for Windows (mintty; incomplete), etc. For consistency and
preventing issues with SSH configurations we will use this on all
platforms.
praveenkumar pushed a commit that referenced this issue Sep 17, 2019
@gbraad @praveenkumar
Issue #598 Force using golang's native SSH implementation
9c5750b 
This solves issues when using non-standard SSH clients, like wrappers
or incomplete implementation, as mostly found on Windows. Even though
Windows provides a usable client, often we find wrappers around plink
or Git for Windows (mintty; incomplete), etc. For consistency and
preventing issues with SSH configurations we will use this on all
platforms.
praveenkumar pushed a commit that referenced this issue Sep 17, 2019
@gbraad @praveenkumar
Issue #598 Force using golang's native SSH implementation
55d69c5 
This solves issues when using non-standard SSH clients, like wrappers
or incomplete implementation, as mostly found on Windows. Even though
Windows provides a usable client, often we find wrappers around plink
or Git for Windows (mintty; incomplete), etc. For consistency and
preventing issues with SSH configurations we will use this on all
platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbraad gbraad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #598 Force native SSH implementation gbraad-redhat/crc
1 participant
@gbraad