Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests don't run with embedded bundle binary #673

Closed
jsliacan opened this issue Sep 30, 2019 · 1 comment
Closed

Integration tests don't run with embedded bundle binary #673

jsliacan opened this issue Sep 30, 2019 · 1 comment

Comments

@jsliacan
Copy link
Contributor

Running integration tests (independent of the binary) against a compiled binary results in constants.BundleEmbedded returning false as the tests weren't compiled with the binary.

Suggested solution is to pass a flag to make integration specifying if the bundle is embedded or not.
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 1, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
8b526e1
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 1, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
66a0fd1
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 1, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
bf25e35
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 2, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
9d2da42
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 2, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
af69314
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
9ee2319
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
4e5fe5a
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
91bc3de
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
246edbb
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
19e676b
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
96803fa
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
79d48fe
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
0094e1c
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
415d85b
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
655970b
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 8, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
8603509
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 15, 2019
@jsliacan
Issue crc-org#673 Implemented specific CRC binary location
26c6a4c
@jsliacan jsliacan mentioned this issue Oct 15, 2019
Merged
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 21, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
bfd5c67
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 23, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
5bd35f7 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 24, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
b12f490 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 24, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
bcc3c53 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
@jsliacan jsliacan mentioned this issue Oct 24, 2019
Closed
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 25, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
da67e6d 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Oct 29, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
6f065c8 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Nov 1, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
3f2b35d 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Nov 4, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
ea447cc 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Nov 4, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
76b2177 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Nov 4, 2019
@jsliacan
Issue crc-org#673 Integration tests run with embedded bundle binary
5a5bd5f
jsliacan added a commit to jsliacan/crc that referenced this issue Nov 5, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
1bd0574 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
jsliacan added a commit to jsliacan/crc that referenced this issue Nov 11, 2019
@jsliacan
Issue crc-org#673, crc-org#647 Discern if bundle embedded, specify bi…
d8ef705 
…nary for tests, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
praveenkumar pushed a commit that referenced this issue Nov 11, 2019
@jsliacan @praveenkumar
Issue #673, #647 Discern if bundle embedded, specify binary for tests…
43f78de 
…, and other updates

- Pass arguments to make integration via flags to go test (that underlies make integration).
- Let user specify which `crc` binary they want to use with integration tests.
- Make tests run with embedded and non-embedded bundle.
- Other additions: relevant docs, clean-up in a feature.
@jsliacan
Copy link
Contributor Author

Resolved via #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsliacan