You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify compatibility of the new excel-streaming-reader version with existing dependencies
Ensure that the new version of excel-streaming-reader (5.0.1) is compatible with the other dependencies, especially since poi-shared-strings was removed. It's important to verify that this new version does not implicitly depend on a specific version of poi-shared-strings or any other library that might conflict with the existing dependencies.
-ivy"com.github.pjfanning:excel-streaming-reader:5.0.1",+ivy"com.github.pjfanning:excel-streaming-reader:5.0.1", # Ensure compatibility with other dependencies
Suggestion importance[1-10]: 8
Why: Ensuring compatibility of the new excel-streaming-reader version with existing dependencies is crucial to avoid runtime issues or conflicts, especially since poi-shared-strings was removed. This suggestion addresses a potential major issue.
Check compatibility of the updated excel-streaming-reader with other project dependencies
Ensure that the new version of excel-streaming-reader (5.0.0) is compatible with the other dependencies, especially since poi-shared-strings was removed. Compatibility issues could arise with major version changes.
-ivy"com.github.pjfanning:excel-streaming-reader:5.0.0",+ivy"com.github.pjfanning:excel-streaming-reader:5.0.0", # Ensure compatibility with other dependencies
Suggestion importance[1-10]: 8
Why: Ensuring compatibility when updating a dependency, especially with a major version change, is crucial to prevent potential runtime issues. The suggestion is valid and adds a useful comment for future maintainers.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
PR Type
dependencies
Description
poi-shared-strings
dependency as it is not needed byspark-excel
.excel-streaming-reader
dependency from version 4.3.1 to 5.0.1.Changes walkthrough 📝
build.sc
Remove
poi-shared-strings
and upgradeexcel-streaming-reader
dependency
build.sc
poi-shared-strings
dependency.excel-streaming-reader
dependency from version 4.3.1 to5.0.1.