Enable multiple parallel calls #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a CI/CD environment, it is possible that multiple jobs are running in parallel. In such case, the script will fail because the dmg file is already created by another job. This commit adds a the PID of the process creating the dmg file to the name of the temporary dmg file. It also uses -mountrandom to mount the dmg file in a random directory. This way, multiple jobs can run in parallel. Signed-off-by: Mikaël Barbero <mikael.barbero@eclipse-foundation.org>
|
This will be a great addition. Happened to me lots of times. |
|
@mbarbero - Consider the attached patch as a part of your contribution. I've noticed that hdiutil can sometimes create the temporary disk image with multiple partitions, causing your determination of the mount directory to fail. This seems to occur during the creation of very large disk images (100s of gigs). The patch implements a function to search for partitions beyond the first /dev/diskNNs1 and returns after awk returns something other than null. |
hdiutil can sometimes create the temporary disk image with multiple partitions, causing your determination of the mount directory to fail. This seems to occur during the creation of very large disk images (100s of gigs). Credits: @mly-intuitive * https://github.com/mly-intuitive * create-dmg#152 (comment) Signed-off-by: Mikaël Barbero <mikael.barbero@eclipse-foundation.org>
Thanks @mly-intuitive, I've integrated your patch in bca0472 |
aonez
reviewed
Sep 19, 2023
aonez
added a commit
that referenced
this pull request
Sep 19, 2023
`/Volumes` fails in sandbox environments #152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a CI/CD environment, it is possible that multiple jobs are running in parallel. In such case, the script will fail because the dmg file is already created by another job.
This commit adds a the PID of the process creating the dmg file to the name of the temporary dmg file. It also uses -mountrandom to mount the dmg file in a random directory. This way, multiple jobs can run in parallel.