New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README example not working #204

Open

wmcmurray wants to merge 1 commit into creativelifeform:master from wmcmurray:patch-1

wmcmurray commented Apr 1, 2022 •

edited

Loading

The usage example in the README did not work out of the box,
here is what has been fixed :

missing imports
imports that were not used
emitter.emit() was not called
onStart, onUpdate, onEnd were undefined
system.update() was not called
I also simplified the example a bit

Some of those problems were pointed out in #191, but the issue was closed without any fix.. ( also here : #174 (comment) )


          Fix README example not working

marwie commented Nov 5, 2022

Thanks for this PR - sad that it wasnt merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet