Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sign your PR" reminder is missing in CONTRIBUTING.md #59

Open
lenicatko opened this issue Jan 6, 2023 · 5 comments
Open

"Sign your PR" reminder is missing in CONTRIBUTING.md #59

lenicatko opened this issue Jan 6, 2023 · 5 comments

Comments

@lenicatko
Copy link

Contributing.md doesn't mention sign-off. I realized that only after creating PR, that I am missing my signature. Adding it there would be very helpful for a new contributor.

Adding the same section as it is in this repository could fix it: https://github.com/cri-o/cri-o/blob/main/CONTRIBUTING.md#sign-your-prs

@haircommander
Copy link
Member

good find!

@haircommander
Copy link
Member

do you have interest in submitting a PR to fix (or include it in #58) or would you like me to?

@lenicatko
Copy link
Author

@haircommander Sure, I can do that, I just wanted to ask if you want me to just add the link to the other repository or it is better to paste the entire section text here as well?

lenicatko added a commit to lenicatko/cri-o.io that referenced this issue Jan 10, 2023
lenicatko added a commit to lenicatko/cri-o.io that referenced this issue Jan 10, 2023
Signed-off-by: Lenka Bocincova <lbocinco@redhat.com>
@haircommander
Copy link
Member

I find myself thinking about maintenance overhead. Maybe adding a line For additional tips on contribution, check out the upstream documentation with a link to it? Then we only have to edit in one place

@lenicatko
Copy link
Author

@haircommander good thinking! Let me add a commit to my opened PR.

lenicatko added a commit to lenicatko/cri-o.io that referenced this issue Jan 10, 2023
Signed-off-by: Lenka Bocincova <lbocinco@redhat.com>
lenicatko added a commit to lenicatko/cri-o.io that referenced this issue Jan 10, 2023
Signed-off-by: Lenka Bocincova <lbocinco@redhat.com>
lenicatko added a commit to lenicatko/cri-o.io that referenced this issue Jan 17, 2023
Signed-off-by: Lenka Bocincova <lbocinco@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants