Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42547: [release-1.31] : config: fix validation of allowed annotations #8710

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #8628

/assign haircommander

fix a bug where an `allowed_annotation` specified twice (in either a workload or runtime) couldn't be used

If an annotation was allowed twice by a workload or runtime
it should be allowed in the resulting list. Also fix a comment
and add a test

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-42547 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.31] : config: fix validation of allowed annotations

In response to this:

This is an automated cherry-pick of #8628

/assign haircommander

fix a bug where an `allowed_annotation` specified twice (in either a workload or runtime) couldn't be used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 24, 2024
@openshift-ci openshift-ci bot changed the title [release-1.31] OCPBUGS-42547: config: fix validation of allowed annotations [release-1.31] : config: fix validation of allowed annotations Oct 24, 2024
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-42547, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42547 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-42547 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.31] : config: fix validation of allowed annotations

In response to this:

This is an automated cherry-pick of #8628

/assign haircommander

fix a bug where an `allowed_annotation` specified twice (in either a workload or runtime) couldn't be used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 24, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #8628

/assign haircommander

fix a bug where an `allowed_annotation` specified twice (in either a workload or runtime) couldn't be used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2024
@haircommander haircommander changed the title [release-1.31] : config: fix validation of allowed annotations OCPBUGS-42547: [release-1.31] : config: fix validation of allowed annotations Oct 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 24, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42547, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42547 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #8628

/assign haircommander

fix a bug where an `allowed_annotation` specified twice (in either a workload or runtime) couldn't be used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 24, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.75%. Comparing base (9704b0c) to head (f334f80).
Report is 2 commits behind head on release-1.31.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.31    #8710      +/-   ##
================================================
+ Coverage         46.73%   46.75%   +0.01%     
================================================
  Files               153      153              
  Lines             22035    22035              
================================================
+ Hits              10298    10302       +4     
+ Misses            10669    10666       -3     
+ Partials           1068     1067       -1     

@openshift-merge-bot openshift-merge-bot bot merged commit dee7150 into cri-o:release-1.31 Oct 24, 2024
58 of 59 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42547: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42547 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #8628

/assign haircommander

fix a bug where an `allowed_annotation` specified twice (in either a workload or runtime) couldn't be used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

/cherry-pick release-1.30

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #8712

In response to this:

/cherry-pick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants