-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-42547: [release-1.31] : config: fix validation of allowed annotations #8710
OCPBUGS-42547: [release-1.31] : config: fix validation of allowed annotations #8710
Conversation
If an annotation was allowed twice by a workload or runtime it should be allowed in the resulting list. Also fix a comment and add a test Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-42547 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: /retitle [release-1.31] : config: fix validation of allowed annotations In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-42547, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42547, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kwilczynski, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.31 #8710 +/- ##
================================================
+ Coverage 46.73% 46.75% +0.01%
================================================
Files 153 153
Lines 22035 22035
================================================
+ Hits 10298 10302 +4
+ Misses 10669 10666 -3
+ Partials 1068 1067 -1 |
dee7150
into
cri-o:release-1.31
@openshift-cherrypick-robot: Jira Issue OCPBUGS-42547: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-42547 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-1.30 |
@haircommander: new pull request created: #8712 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #8628
/assign haircommander