Integration tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing the below issue. @pytest.mark.xfail(reason="'owner_name' is None for some reason. Investigate.") The assertion was false because the database didn't have an owner set, setting an owner during data preparation fixed the issues. The code is behaving as expected.
There's an assertion that fails, I leave it here on purpose. My current assumption is that the metastore overrides some of the passed options with defaults. "MANAGED_TABLE" is the default value for tableType See here for the defaults: https://github.com/apache/hive/blob/14a1f70607db5ae6cf71b6d4343f308a5167581c/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java#L69C43-L69C43 Something similar happens also when you choose a "VIRTUAL_VIEW" table type, where the metastore overrides the storage descriptor removing in the location the file:: prefix. These are some very basic integration tests, more to come.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic tests for fetching tables and columns. At least for the basic types it seems to work fine. I'll be adding more tests to cover all the different types but it should be ok to start playing around with converting the types into Recap. Btw, there's a failing assertion in the tests right now but check my commit comments and the source code for that.