TEMP: Rails 7.1 default: add_autoload_paths_to_load_path = true (temporarily) #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veganstraightedge
changed the title
veganstraightedge
requested review from
astronaut-wannabe,
bookis,
eliduke,
evanphx,
guitsaru and
just1602
as code owners
just1602
approved these changes
Mar 6, 2024
|
Nice find! I'm surprised that the configuration for autoload-paths (for ruby files) would intersect with I18n's paths (for yml files). Glad it works! |
|
@bensheldon I was surprised by that too! This is probably good for us anyhow. I've wanted to revisit our locales and yaml files approach, with lessons learned over the past 7 years. |
veganstraightedge
added a commit
that referenced
this pull request
Mar 11, 2024
Following up #3799, we can now version bump `config.load_defaults` from `7.0` to `7.1` This make us best prepared for a future `7.2` or `8.0` release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finished framework defaults 7.1 file
Changes
Overrides a 7.1 default for
config.add_autoload_paths_to_load_pathoffalsewithtrue, for nowIt needs to be
trueuntil we rethink how to handle allowing nested directories in locales folders.But doing this first allows up to bump
load_defaults 7.0to7.1