Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum backfill data migration #3936

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Enum backfill data migration #3936

merged 8 commits into from
Sep 10, 2024

Conversation

veganstraightedge
Copy link
Contributor

Follows #3925

This PR is the first of few to migrate the few enums (backed by integers) to ones backed by strings

  1. add new columns, with temp_ in the name and prefix: true to avoid method namespace collision with existing enums
  2. backfill data migration to populate new column with the string equivalent of the integer column (0 => draft, etc)

This PR does 1 and 2 from #3925

@veganstraightedge veganstraightedge merged commit db23795 into main Sep 10, 2024
7 checks passed
@veganstraightedge veganstraightedge deleted the enum_backfill_data_migration branch September 10, 2024 03:14
@veganstraightedge veganstraightedge mentioned this pull request Sep 10, 2024
Merged
veganstraightedge added a commit that referenced this pull request Sep 10, 2024
@veganstraightedge
Use string enum columns instead of integer enum columns (#3937)
9fcbcab 
Continuing:

- #3925 
- #3936

this PR does 3, 4, and 5 from #3925 

> 1. ...
> 2. ...
> 3. move references from the enums to the new enums
> 4. drop the old column and old enums
> 5. rename new enums and columns back to what they were before (remove
`temp_` prefix and `prefix: true`)
@veganstraightedge veganstraightedge mentioned this pull request Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astronaut-wannabe astronaut-wannabe Awaiting requested review from astronaut-wannabe astronaut-wannabe is a code owner

@bookis bookis Awaiting requested review from bookis bookis is a code owner

@eliduke eliduke Awaiting requested review from eliduke eliduke is a code owner

@evanphx evanphx Awaiting requested review from evanphx evanphx is a code owner

@guitsaru guitsaru Awaiting requested review from guitsaru guitsaru is a code owner

@just1602 just1602 Awaiting requested review from just1602 just1602 is a code owner

Assignees
No one assigned
Labels
↔️ migrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@veganstraightedge