Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RDPPort to vagrant winrm-config #7

Merged
merged 1 commit into from
Mar 26, 2015
Merged

Add RDPPort to vagrant winrm-config #7

merged 1 commit into from
Mar 26, 2015

Conversation

fnichol
Copy link
Contributor

@fnichol fnichol commented Mar 26, 2015

Hello, and thank you for this Vagrant plugin, it is exactly what I was going to sit down and write this afternoon.

I'd like to use this plugin to support the Vagrant Driver for Test Kitchen when dealing with Windows instances. You can take a peek at test-kitchen/kitchen-vagrant#155 if you want to see what I'm using this for.

Test Kitchen has a kitchen login method, not unlike vagrant ssh or recently vagrant rdp, and as we're all still waiting for WinRM Remoting from non-Windows systems, it seems like launching an RDP session is the thing to do in the meantime.

I'm wondering how receptive this project would be to adding/exposing the RDP Port to the vagrant winrm-config data hash. The name and/or implementation may not be 100%, but I wanted to see what an implementation looked like (and I have to solve this problem anyway for Test Kitchen). Thoughts?

Thanks again!

@Annih
Copy link
Contributor

Annih commented Mar 26, 2015

Seems good to me, I have no issue to integrate the rdp config in it.
Thanks to use and improve this plugin :)

Annih added a commit that referenced this pull request Mar 26, 2015
Add RDPPort to `vagrant winrm-config`
@Annih Annih merged commit 09573c5 into criteo:master Mar 26, 2015
@fnichol
Copy link
Contributor Author

fnichol commented Mar 26, 2015

@Annih Major thanks to you, quickest turnaround ever!

1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants