allow specifiying custom image url #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There needs to be a test. I probably need to create a new repository containing a VM image. |
|
Since this is TypeScript, the code needs to be compiled to JavaScript. You need to run |
|
Addressed all the comments and have updated the PR. |
|
Please update the readme and the changelog as well. |
|
added |
src/action/action.ts
Outdated
| const result = await cache.downloadTool( | ||
| this.operatingSystem.virtualMachineImageUrl | ||
| ) | ||
| const imageURL = `this.input.imageURL !== '' ? this.input.imageURL : this.operatingSystem.virtualMachineImageUrl` |
There was a problem hiding this comment.
This doesn't look right. The whole expression on the right hand side is a string.
There was a problem hiding this comment.
oops, yes you are right.
Fixed.
Signed-off-by: Aisha Tammy <floss@bsd.ac>
|
I've created a new repository for a custom VM image [1]. Could you please add a test for that? [1] https://github.com/cross-platform-actions/test-custom-image-builder/releases/tag/v1.0.0 |
|
Merged in: 12af1e9. |
korli
added a commit
to korli/action
that referenced
this pull request
Mar 15, 2024
Release 0.18.0 Added - Add support for custom image URLs ([cross-platform-actions#13](cross-platform-actions#13)) - Add architecture alias for x86-64: x64 ([cross-platform-actions#58](cross-platform-actions#58))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aisha Tammy floss@bsd.ac
First time working on a github action, so may have made some mistakes.
This is in conjunction with the PR to build OpenBSD snapshot images on the openbsd-builder.