Merge #1151

1151: Replace atty with is-terminal. r=Emilgardis a=Alexhuszagh

Although this doesn't affect cross (since we do not use custom allocators), this address [rustsec-1457](rustsec/advisory-db#1457).

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>

Cargo.toml

@@ -26,7 +26,7 @@ dev = []
 members = ["xtask"]
 
 [dependencies]
-atty = "0.2"
+is-terminal = "0.4.0"
 clap = { version = "4.0", features = ["derive"] }
 color-eyre = { version = "0.6.2", default-features = false, features = ["track-caller"] }
 eyre = "0.6"

deny.toml

@@ -12,7 +12,11 @@ vulnerability = "deny"
 unmaintained = "deny"
 notice = "deny"
 unsound = "deny"
-ignore = []
+# FIXME: remove this if/when clap changes to is-terminal, atty is
+# patched, or we migrated to an MSRV of 1.66.0.
+ignore = [
+    "RUSTSEC-2021-0145",
+]
 
 [bans]
 multiple-versions = "deny"

src/shell.rs

@@ -8,6 +8,7 @@ use std::str::FromStr;
 
 use crate::config::bool_from_envvar;
 use crate::errors::Result;
+use is_terminal::IsTerminal;
 use owo_colors::{self, OwoColorize};
 
 // get the prefix for stderr messages
@@ -441,32 +442,42 @@ fn get_verbosity(
 }
 
 pub trait Stream {
-    const TTY: atty::Stream;
+    type TTY: IsTerminal;
     const OWO: owo_colors::Stream;
 
     #[must_use]
-    fn is_atty() -> bool {
-        atty::is(Self::TTY)
-    }
+    fn is_atty() -> bool;
 
     fn owo(&self) -> owo_colors::Stream {
         Self::OWO
     }
 }
 
 impl Stream for io::Stdin {
-    const TTY: atty::Stream = atty::Stream::Stdin;
+    type TTY = io::Stdin;
     const OWO: owo_colors::Stream = owo_colors::Stream::Stdin;
+
+    fn is_atty() -> bool {
+        io::stdin().is_terminal()
+    }
 }
 
 impl Stream for io::Stdout {
-    const TTY: atty::Stream = atty::Stream::Stdout;
+    type TTY = io::Stdout;
     const OWO: owo_colors::Stream = owo_colors::Stream::Stdout;
+
+    fn is_atty() -> bool {
+        io::stdout().is_terminal()
+    }
 }
 
 impl Stream for io::Stderr {
-    const TTY: atty::Stream = atty::Stream::Stderr;
+    type TTY = io::Stderr;
     const OWO: owo_colors::Stream = owo_colors::Stream::Stderr;
+
+    fn is_atty() -> bool {
+        io::stderr().is_terminal()
+    }
 }
 
 pub fn default_ident() -> usize {