-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporarily disable broken targets #231
Conversation
Can someone please add a cron job to run cross CI daily ? It takes 2 seconds to add such a cron job to travis, and it would allow us to detect when master breaks cross, as well as to save some headaches to those submitting PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gnzlbg !
bors r+
@gnzlbg I also added a daily cron job: https://screenshots.firefox.com/W3my389ZfDoiFoWr/travis-ci.org |
Awesome, thank you @jamesmunns, it would be great if you would get an email on failure, and could open an issue on the repo so that we can try to quickly find which rust PR broke things. If we identify them quickly, we can either revert them, or maybe the fix becomes obvious. |
Yeah I'll do that later today and close #228 myself. |
Timed out |
bors: retry |
Build failed |
So I've also disabled |
@gnzlbg cool i'll create a tracking issue for that |
bors: r+ |
Thinking about this, would a weekly Cron work for this? These tests take ~3 hours with all builders available, which ends up being an unfortunate amount of our total CI time. |
I'd prefer to have a release soon so that people can use the tagged version instead of master which will be a lesser burden for us |
What we need is a cron job every time there is a new nightly. Given that I just had to amend this PR because asmjs broke on nightly, I'd say a daily job is the minimum required. One can configure the cron jobs so that they not run if a job already ran on master on the same day. |
Build succeeded |
@gnzlbg yes a daily cron is needed but that could mess with existing builds since each build takes roughly 2-3 hours, which means it could block other PRs. We could sort this out by setting a priority (bors makes it easy with |
No description provided.