Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable broken targets #231

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Nov 16, 2018

No description provided.

@gnzlbg gnzlbg requested review from Dylan-DPC-zz, jamesmunns and a team as code owners November 16, 2018 09:02
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 16, 2018

Can someone please add a cron job to run cross CI daily ?

It takes 2 seconds to add such a cron job to travis, and it would allow us to detect when master breaks cross, as well as to save some headaches to those submitting PRs.

jamesmunns
jamesmunns previously approved these changes Nov 16, 2018
Copy link
Contributor

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gnzlbg !

bors r+

bors bot added a commit that referenced this pull request Nov 16, 2018
231: temporarily disable broken targets r=jamesmunns a=gnzlbg



Co-authored-by: gnzlbg <gonzalobg88@gmail.com>
@jamesmunns
Copy link
Contributor

@gnzlbg I also added a daily cron job: https://screenshots.firefox.com/W3my389ZfDoiFoWr/travis-ci.org

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 16, 2018

Awesome, thank you @jamesmunns, it would be great if you would get an email on failure, and could open an issue on the repo so that we can try to quickly find which rust PR broke things.

If we identify them quickly, we can either revert them, or maybe the fix becomes obvious.

@jamesmunns
Copy link
Contributor

@gnzlbg will do. Would you mind opening issues to fix each of the targets that are disabled here?

I'd like to close #228, and instead have one issue per arch that doesn't work.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 16, 2018

Yeah I'll do that later today and close #228 myself.

@bors
Copy link
Contributor

bors bot commented Nov 16, 2018

Timed out

@Dylan-DPC-zz
Copy link

bors: retry

bors bot added a commit that referenced this pull request Nov 16, 2018
231: temporarily disable broken targets r=jamesmunns a=gnzlbg



Co-authored-by: gnzlbg <gonzalobg88@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 16, 2018

Build failed

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 16, 2018

So I've also disabled asmjs. The emscripten backend of rustc was updated recently (rust-lang/rust#55626), and there have been a couple of related PRs since then, so maybe these broke it (emscripten is using an older LLVM version for asm.js).

@Dylan-DPC-zz
Copy link

@gnzlbg cool i'll create a tracking issue for that

@Dylan-DPC-zz
Copy link

bors: r+

bors bot added a commit that referenced this pull request Nov 16, 2018
231: temporarily disable broken targets r=Dylan-DPC a=gnzlbg



Co-authored-by: gnzlbg <gonzalobg88@gmail.com>
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 16, 2018
@jamesmunns
Copy link
Contributor

Thinking about this, would a weekly Cron work for this? These tests take ~3 hours with all builders available, which ends up being an unfortunate amount of our total CI time.

@Dylan-DPC-zz
Copy link

I'd prefer to have a release soon so that people can use the tagged version instead of master which will be a lesser burden for us

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 16, 2018

What we need is a cron job every time there is a new nightly. Given that I just had to amend this PR because asmjs broke on nightly, I'd say a daily job is the minimum required. One can configure the cron jobs so that they not run if a job already ran on master on the same day.

@bors
Copy link
Contributor

bors bot commented Nov 16, 2018

Build succeeded

@bors bors bot merged commit 15a02f0 into cross-rs:master Nov 16, 2018
@Dylan-DPC-zz
Copy link

@gnzlbg yes a daily cron is needed but that could mess with existing builds since each build takes roughly 2-3 hours, which means it could block other PRs. We could sort this out by setting a priority (bors makes it easy with bors: p=..) but that will mean ensuring we do it for every PR (or at least those that run during the cron) which won't scale well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants