-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.15 #302
Release 0.1.15 #302
Conversation
r? @jamesmunns (rust_highfive has picked a reviewer for you, use r? to override) |
1ba1984
to
cd222eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote nits...
@reitermarkus When the qemu-system supporting was added in #153 and #166 no documentation was provided... It would be great if some documentation could be added before a new release (I can't write it myself now, but maybe someone can). By the way, thanks for moving the project forward, you are doing a great work! |
I think typographic quotes should be preferred for prose.
I'm not using the |
cd222eb
to
180e344
Compare
bors r+ |
👎 Rejected by code reviews |
These are english text files, often processed on the command line. Typographic quotes are a dime a dozen and will cause random problems for people working with those documents. Until there's a very good reason to deviate I'd rather we stick to plain ASCII. |
And that's exactly the reason why we should use quotes appropriate for English text. This is a Markdown file, there is no good reason why this file would ever be processed by a tool which doesn't support UTF-8 or HTML escape codes. |
Let's not waste time bike-shedding such small things, it's a release note, we can always modify it later |
Let's not waste time bike-shedding such small things, it's a release note, we can always modify it later
bors: r+ |
Build succeeded
|
No, we cannot. If it's released it will part of the release. Apart from that the point is not to include a change that was not there but to NOT make an incorrect change. |
@Dylan-DPC Also I'd appreciate if you did not simply dismiss a members concern. |
No description provided.