Fix cross when stdin is not a TTY #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
requested review from
Dylan-DPC-zz,
jamesmunns and
a team
as code owners
|
r? @jamesmunns (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
reitermarkus
requested changes
Sep 10, 2019
CryZe
force-pushed
the
non-interactive
branch
from
ba5182a
to
8003113
Compare
CryZe
force-pushed
the
non-interactive
branch
from
8003113
to
eb5f822
Compare
When stdin is not a TTY, cross fails because it still passes `-i` to `docker run`, which makes Docker fail like so: ``` the input device is not a TTY ``` Apparently GitHub Actions doesn't have a TTY as stdin, so this is the fix to make cross work with GitHub Actions.
CryZe
force-pushed
the
non-interactive
branch
from
eb5f822
to
d64cfb8
Compare
reitermarkus
approved these changes
Sep 10, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2019
319: Fix cross when stdin is not a TTY r=reitermarkus a=CryZe When stdin is not a TTY, cross fails because it still passes `-i` to `docker run`, which makes Docker fail like so: ``` the input device is not a TTY ``` Apparently GitHub Actions doesn't have a TTY as stdin, so this is the fix to make cross work with GitHub Actions. Co-authored-by: Christopher Serr <christopher.serr@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stdin is not a TTY, cross fails because it still passes
-itodocker run, which makes Docker fail like so:Apparently GitHub Actions doesn't have a TTY as stdin, so this is the fix to make cross work with GitHub Actions.