Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade WINE versions to 7.0. #737

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Upgrade WINE versions to 7.0. #737

merged 1 commit into from
Jun 1, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Updates from WINE 3.0 to 7.0 on *-pc-windows-gnu images using binary releases provide by WINE HQ.

Closes #390.

@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 1, 2022 17:25
Emilgardis
Emilgardis approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jun 1, 2022
@bors @Alexhuszagh
Merge #737
f65c5af 
737: Upgrade WINE versions to 7.0. r=Emilgardis a=Alexhuszagh

Updates from WINE 3.0 to 7.0 on `*-pc-windows-gnu` images using binary releases provide by WINE HQ.

Closes #390.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@Alexhuszagh
Upgrade WINE versions to 7.0.
e93562a 
Updates from WINE 3.0 to 7.0 on `*-pc-windows-gnu` images using binary
releases provide by WINE HQ.

Closes cross-rs#390.
@bors
Copy link
Contributor

bors bot commented Jun 1, 2022

Canceled.

@Alexhuszagh
Copy link
Contributor Author

I forgot I committed this from Windows after having set permissions on WSL, so wine.sh wasn't executable. This has been fixed, it should build now.

Emilgardis
Emilgardis approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@Alexhuszagh
Copy link
Contributor Author

bors try --target x86_64-pc-windows-gnu

bors bot added a commit that referenced this pull request Jun 1, 2022
@bors
Try #737: --target x86_64-pc-windows-gnu
ca7a67c
bors bot added a commit that referenced this pull request Jun 1, 2022
@bors @Alexhuszagh
Merge #737
4ac7de3 
737: Upgrade WINE versions to 7.0. r=Emilgardis a=Alexhuszagh

Updates from WINE 3.0 to 7.0 on `*-pc-windows-gnu` images using binary releases provide by WINE HQ.

Closes #390.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@Emilgardis
Copy link
Member

lets just r+ it, if it works it works

@Alexhuszagh
Copy link
Contributor Author

bors cancel
bors r=Emilgardis

@bors
Copy link
Contributor

bors bot commented Jun 1, 2022

Canceled.

@bors
Copy link
Contributor

bors bot commented Jun 1, 2022

try

Build succeeded:

@bors
Copy link
Contributor

bors bot commented Jun 1, 2022

Build succeeded:

@bors bors bot merged commit 771ce9d into cross-rs:main Jun 1, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added the A-wine Area: wine runners label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
A-wine Area: wine runners
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.

Update windows-build images or WINE version to fix KERNEL32.dll.GetQueuedCompletionStatusEx
2 participants
@Alexhuszagh @Emilgardis