Skip to content
This repository has been archived by the owner on Nov 5, 2018. It is now read-only.

Remove AtomicOption #11

Merged
1 commit merged into from Mar 11, 2018
Merged

Remove AtomicOption #11

1 commit merged into from Mar 11, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2018

Closes #2.

AtomicOption is unsound and is probably not worth repairing. Let's replace it with AtomicCell from crossbeam-rs/rfcs#28 as soon as possible.

@Vtec234
Copy link
Member

Vtec234 commented Mar 6, 2018

Agreed, but currently scoped.rs uses AtomicOption so we might have to wait until new types are added before merging this.

As a side note, if we want to replace AtomicOption with AtomicCell, this would create a dependency of utils on atomic, so another reason to just put that type in utils instead.

@ghost
Copy link
Author

ghost commented Mar 7, 2018

Rebased on master, where scoped.rs doesn't depend on AtomicOption anymore.

@Vtec234 I'm beginning to agree... We should address these dependency shenanigans somehow.

@ghost ghost merged commit b99fd71 into crossbeam-rs:master Mar 11, 2018
@ghost ghost deleted the remove-atomic-option branch March 11, 2018 10:50
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant