Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin nightly to 2024-05-04 due to recently-enabled check-cfg #1109

Closed
wants to merge 3 commits into from
Closed

Pin nightly to 2024-05-04 due to recently-enabled check-cfg #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8f4191
Pin nightly
ryoqun May 15, 2024
38c5e20
Pin nightly in Cirrus CI as well
ryoqun May 15, 2024
2f74d0f
Add TODO comment
ryoqun May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ aarch64_linux_task:
arm_container:
image: rust
setup_script:
- rustup toolchain add nightly && rustup default nightly
# TODO: Pin nightly due to: https://github.com/rust-lang/rust/issues/124800
- rustup toolchain add nightly-2024-05-04 && rustup default nightly-2024-05-04
test_script:
- cargo test --all --all-features --exclude benchmarks -- --test-threads=1
- cargo test --all --all-features --exclude benchmarks --release -- --test-threads=1
Expand All @@ -28,7 +29,8 @@ aarch64_macos_task:
macos_instance:
image: ghcr.io/cirruslabs/macos-ventura-xcode
setup_script:
- curl --proto '=https' --tlsv1.2 -fsSL --retry 10 --retry-connrefused https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain nightly --no-modify-path
# TODO: Pin nightly due to: https://github.com/rust-lang/rust/issues/124800
- curl --proto '=https' --tlsv1.2 -fsSL --retry 10 --retry-connrefused https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain nightly-2024-05-04 --no-modify-path
test_script:
- . "$HOME/.cargo/env"
- cargo test --all --all-features --exclude benchmarks -- --test-threads=1
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ concurrency:

jobs:
# Test crates on their minimum Rust versions and nightly Rust.
# TODO: Pin nightly due to: https://github.com/rust-lang/rust/issues/124800
test:
env:
RUST_VERSION: ${{ matrix.rust }}
Expand All @@ -48,18 +49,18 @@ jobs:
os: ubuntu-latest
- rust: stable
os: windows-latest
- rust: nightly
- rust: nightly-2024-05-04
os: ubuntu-latest
- rust: nightly
- rust: nightly-2024-05-04
os: windows-latest
- rust: nightly
- rust: nightly-2024-05-04
os: ubuntu-latest
target: i686-unknown-linux-gnu
- rust: nightly
- rust: nightly-2024-05-04
os: ubuntu-latest
target: armv7-unknown-linux-gnueabihf
# Test 32-bit target that does not have AtomicU64/AtomicI64.
- rust: nightly
- rust: nightly-2024-05-04
os: ubuntu-latest
target: armv5te-unknown-linux-gnueabi
runs-on: ${{ matrix.os }}
Expand All @@ -85,7 +86,7 @@ jobs:
matrix:
rust:
- msrv
- nightly
- nightly-2024-05-04
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
Expand All @@ -105,7 +106,7 @@ jobs:
steps:
- uses: taiki-e/checkout-action@v1
- name: Install Rust
run: rustup update nightly && rustup default nightly
run: rustup update nightly-2024-05-04 && rustup default nightly-2024-05-04
- name: Install cargo-hack
uses: taiki-e/install-action@cargo-hack
- name: Install cargo-minimal-versions
Expand Down Expand Up @@ -179,7 +180,7 @@ jobs:
steps:
- uses: taiki-e/checkout-action@v1
- name: Install Rust
run: rustup toolchain install nightly --component miri && rustup default nightly
run: rustup toolchain install nightly-2024-05-04 --component miri && rustup default nightly-2024-05-04
- name: miri
run: ci/miri.sh

Expand All @@ -190,7 +191,7 @@ jobs:
steps:
- uses: taiki-e/checkout-action@v1
- name: Install Rust
run: rustup toolchain install nightly --component rust-src && rustup default nightly
run: rustup toolchain install nightly-2024-05-04 --component rust-src && rustup default nightly-2024-05-04
- uses: taiki-e/install-action@cargo-careful
- name: Run cargo-careful
run: ci/careful.sh
Expand All @@ -202,7 +203,7 @@ jobs:
steps:
- uses: taiki-e/checkout-action@v1
- name: Install Rust
run: rustup update nightly && rustup default nightly
run: rustup update nightly-2024-05-04 && rustup default nightly-2024-05-04
# https://github.com/google/sanitizers/issues/1716 / https://github.com/actions/runner-images/issues/9491
- run: sudo sysctl vm.mmap_rnd_bits=28
- name: Run sanitizers
Expand All @@ -226,7 +227,7 @@ jobs:
steps:
- uses: taiki-e/checkout-action@v1
- name: Install Rust
run: rustup update nightly && rustup default nightly
run: rustup update nightly-2024-05-04 && rustup default nightly-2024-05-04
- name: docs
run: cargo doc --no-deps --all --all-features

Expand Down