Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal versions check to travis #341

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Add minimal versions check to travis #341

merged 1 commit into from
Mar 10, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Mar 10, 2019

@taiki-e
Copy link
Member Author

taiki-e commented Mar 10, 2019

(If adding rand (0.6 or later) to dependencies (not dev-dependencies) in the future, I think this hack in futures-rs is helpful: rust-lang/futures-rs#1425)

ghost
ghost suggested changes Mar 10, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks so much for putting effort into this! Before merging, I think we could simplify things a bit by having a single cargo check inside dependencies.sh rather than adding additional cargo checks to all other CI scripts.

ci/dependencies.sh Show resolved Hide resolved
@ghost
Copy link

ghost commented Mar 10, 2019

Looks like the tests are failing. Perhaps we need to drop --bins too?

@taiki-e
Copy link
Member Author

taiki-e commented Mar 10, 2019

Yes, in addition, it seems necessary to exclude the benchmarks (crossbeam-channel/benchmarks).

@taiki-e
Copy link
Member Author

taiki-e commented Mar 10, 2019 •
edited
Loading

AFAIK benchmarks are not published, but is it OK to add "publish = false" to Cargo.toml for clarity?

@ghost
Copy link

ghost commented Mar 10, 2019

Yes, publish = false is a good idea since we don't want to publish that crate accidentally.

@ghost
Copy link

ghost commented Mar 10, 2019

bors r+

bors bot added a commit that referenced this pull request Mar 10, 2019
@bors @taiki-e
Merge #341
536b83d 
341: Add minimal versions check to travis r=stjepang a=taiki-e

Related: #312, rust-lang/cargo#5657

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 10, 2019

Build succeeded

@bors bors bot merged commit 8c20ae9 into crossbeam-rs:master Mar 10, 2019
@taiki-e taiki-e deleted the minimal-versions branch March 10, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e