-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release for all crossbeam crates. #474
Conversation
This also bumps the `rand` `dev-dependency` to `0.7`. No breaking changes as far as I can tell.
This also bumps the `rand` `dev-dependency` to `0.7`. No breaking changes as far as I can tell.
This also bumps the `rand` `dev-dependency` to `0.7`. No breaking changes as far as I can tell.
This also bumps the `rand` `dev-dependency` to `0.7`. No breaking changes as far as I can tell.
This also bumps the `rand` `dev-dependency` to `0.7`. No breaking changes as far as I can tell.
This just bumps the `rand` `dev-dependency` to `0.7`. None of the underlying crates had breaking changes, and this crate has no changes, so a patch release is fine.
It looks good to me. Thanks! bors r+ I'll publish the crates soon. |
bors r+ |
Already running a review |
474: Patch release for all crossbeam crates. r=jeehoonkang a=jonhoo This bumps the patch version for all sub-crates and the top-level crate and updates the changelogs with references to PRs where applicable. As far as I can tell, there are no breaking changes. The top-level crate has not change at all, though I bumped `rand` to `0.7` in all the crates, which I guess technically requires a patch bump if we do another release. Fixes #473. Closes #472. Closes #468. Closes #409. Not sure if this also solves #347 by virtue of #458? Co-authored-by: Jon Gjengset <jon@thesquareplanet.com>
CI fails with e.g. https://travis-ci.org/crossbeam-rs/crossbeam/jobs/651554494#L233 @jonhoo any ideas how to fix? |
Bah, looks like |
Do we have an option to leave |
rand 0.7 requires support for the 2018 edition, which only works on 1.32 (our current MSRV is 1.28). This also means that the root crate no longer needs a version bump.
Canceled |
Reverted the |
bors r+ |
474: Patch release for all crossbeam crates. r=jeehoonkang a=jonhoo This bumps the patch version for all sub-crates and the top-level crate and updates the changelogs with references to PRs where applicable. As far as I can tell, there are no breaking changes. The top-level crate has not change at all, though I bumped `rand` to `0.7` in all the crates, which I guess technically requires a patch bump if we do another release. Fixes #473. Closes #472. Closes #468. Closes #409. Not sure if this also solves #347 by virtue of #458? Co-authored-by: Jon Gjengset <jon@thesquareplanet.com>
Build failed |
uh-oh, seems like a real bug... https://travis-ci.org/crossbeam-rs/crossbeam/jobs/651567571#L538 |
Ouch... As far as I can tell from the history, this basically has to be #458 if the bug wasn't already present in the previous release. There is, I suppose, also a slim chance that it is related to #454 in |
It could also be that the test itself is just racy? |
It certainly looks like that might be the case, because it passed just fine here: https://travis-ci.org/crossbeam-rs/crossbeam/builds/651566762 |
Remove `ctrlc` since `3.1.4` is now out. Remove `crossbeam` since it's about to get a release: crossbeam-rs/crossbeam#474
Hmm... I feel we should ping @stjepang for this matter. I'm not familiar with |
I was just looking at Fedora failed builds in that same test, on the current crossbeam-channel 0.4.0. In other words, I think this isn't new, at least.
This loops until failure -- usually I make it 20-30 times successfully. It seems to fail even more frequently with Note: testing "fairness" matches |
Yeah, that'd be my guess. My inclination here would be to merge this and then do a release. The test is probably racy, and isn't caused by this release, so it's not worth holding up the release we wait for Stjepan to have a chance to look at the test to see if the tolerance should be increased. |
@jeehoonkang What do you think? |
Okay, I'm trying again to merge bors retry |
Build succeeded |
@jonhoo I'll release crates now. Would you please create an issue on the CI failure? |
|
@jeehoonkang
I think maybe what happened is that |
@jonhoo sorry, it was my bad. It was resolved in #476. I just published a new version of deque: https://crates.io/crates/crossbeam-deque |
|
This bumps the patch version for all sub-crates and the top-level crate and updates the changelogs with references to PRs where applicable. As far as I can tell, there are no breaking changes. The top-level crate has not change at all, though I bumped
rand
to0.7
in all the crates, which I guess technically requires a patch bump if we do another release.Fixes #473.
Closes #472.
Closes #468.
Closes #409.
Not sure if this also solves #347 by virtue of #458?