Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed size constrait of Local (closes #597) #599

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

jeehoonkang
Copy link
Contributor

@decathorpe Thank you for reporting this. It's also kinda hotfix. As @taiki-e said, we really need CI for i686 and other 32-bit architectures... (#598).

r? @taiki-e

@decathorpe
Copy link

@decathorpe Thank you for reporting this. It's also kinda hotfix. As @taiki-e said, we really need CI for i686 and other 32-bit architectures... (#598).

Looks good to me (since this is basically the "fix" I suggested) :) Thanks!

@jeehoonkang
Copy link
Contributor Author

@taiki-e would you please review again? I'd like it to be merged before #603

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 22, 2020
599: Relaxed size constrait of Local (closes #597) r=taiki-e a=jeehoonkang

@decathorpe Thank you for reporting this.  It's also kinda hotfix.  As @taiki-e said, we really need CI for i686 and other 32-bit architectures... (#598).

r? @taiki-e 

Co-authored-by: Jeehoon Kang <jeehoon.kang@kaist.ac.kr>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2020

Build failed:

@taiki-e
Copy link
Member

taiki-e commented Nov 22, 2020

bors retry

warning: spurious network error

@bors
Copy link
Contributor

bors bot commented Nov 22, 2020

Build succeeded:

@bors bors bot merged commit 262f94d into crossbeam-rs:master Nov 22, 2020
@jeehoonkang jeehoonkang deleted the fix-597 branch January 15, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants