Test and fix for confusing publish error w/ empty clue

crosshare-org · May 6, 2024 · 3f564b9 · 3f564b9
1 parent 0ca43b3
commit 3f564b9
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/app/__tests__/builderReducer.test.ts b/app/__tests__/builderReducer.test.ts
@@ -93,3 +93,16 @@ test('missing refs', () => {
     ]
   `);
 });
+
+test('basic publish errors', () => {
+  const state = getState(['a', 'b', 'c', ' ', ' ', ' ', 'd', 'e', 'f'], {
+    abc: 'test with good enum (3)',
+    def: 'test with bad enum (5)',
+  });
+  expect(builderReducer(state, publish).publishErrors).toMatchInlineSnapshot(`
+    [
+      "All squares in the grid must be filled in",
+      "Puzzle must have a title set",
+    ]
+  `);
+});
diff --git a/app/lib/gridBase.ts b/app/lib/gridBase.ts
@@ -1,4 +1,4 @@
-import { Direction, PosAndDir, Position } from './types';
+import { BLOCK, Direction, EMPTY, PosAndDir, Position } from './types';
 
 export interface EntryBase {
   index: number;
@@ -264,15 +264,15 @@ export function entriesFromCells(
           if (cellVal === undefined || entry === undefined) {
             throw new Error('cellid oob');
           }
-          if (cellVal === '.') {
+          if (cellVal === BLOCK) {
             break;
           }
           entry[dir] = {
             entryIndex: entries.length,
             wordIndex: entryPattern.length,
             cellIndex: wordlen,
           };
-          if (cellVal === ' ') {
+          if (cellVal === EMPTY || cellVal === '') {
             isComplete = false;
           }
           entryCells.push({ row: yt, col: xt });

diff --git a/app/reducers/builderReducer.ts b/app/reducers/builderReducer.ts
@@ -758,6 +758,7 @@ function _builderReducer(
     const missingClues = Object.entries(
       state.grid.entries
         .map((e) => e.completedWord ?? '')
+        .filter((e) => e)
         .reduce((counts: Record<string, number>, entry) => {
           counts[entry] = (counts[entry] ?? 0) + 1;
           return counts;