client url字符串问题，route redis配置更新 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client url字符串多 / ，route redis配置更新
在运行server和route的时候发现会报log4j的错，虽不影响运行但尝试解决，是zkclient下的log4j未配置原因，于是在commen中添加配置文件
| @@ -13,7 +13,7 @@ cim.msg.logger.path = /opt/logs/cim/ | |||
|
|
|||
|
|
|||
| # route url suggested that this is Nginx address | |||
| cim.route.url = http://localhost:8083/ | |||
| cim.route.url = http://localhost:8083 | |||
There was a problem hiding this comment.
It's better to adress the campatibility issue here:
e.g:
String serverUrl = url + "/" + method.getName() ;
URI uri = new URI(serverUrl);
String fixedUrl = uri.normalize().toString();
...
return HttpClient.call(okHttpClient, jsonObject.toString(), fixedUrl);使用uri.normalize校验url规范性，更健壮。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client url字符串多 / ，route redis配置更新