feat(ec2/securitygroup)!: Make region a required field

Signed-off-by: Henrique Oliveira <henrique.antonio@grupoboticario.com.br>
crossplane-contrib · Mar 18, 2024 · 9b5c908 · 9b5c908
1 parent 63b23e4
commit 9b5c908
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/apis/ec2/v1beta1/securitygroup_types.go b/apis/ec2/v1beta1/securitygroup_types.go
@@ -24,13 +24,9 @@ import (
 // SecurityGroupParameters define the desired state of an AWS VPC Security
 // Group.
 type SecurityGroupParameters struct {
-	// TODO(muvaf): Region is a required field but in order to keep backward compatibility
-	// with old Provider type and not bear the cost of bumping to v1beta2, we're
-	// keeping it optional for now. Reconsider before v1beta2 or v1.
 
 	// Region is the region you'd like your SecurityGroup to be created in.
-	// +optional
-	Region *string `json:"region,omitempty"`
+	Region *string `json:"region"`
 
 	// A description of the security group.
 	// +immutable

diff --git a/package/crds/ec2.aws.crossplane.io_securitygroups.yaml b/package/crds/ec2.aws.crossplane.io_securitygroups.yaml
@@ -795,6 +795,7 @@ spec:
                 required:
                 - description
                 - groupName
+                - region
                 type: object
               managementPolicies:
                 default: