Reduce ec2 instance controller API calls for an observation #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EC2 instance controller synchronously makes several DescribeInstanceAttribut calls to the EC2 API and does not use the results. This slows down the reconcile time for a single observation. This removes the API calls for attributes that are returned in `RunInstances`. Signed-off-by: justin.miron <justin.miron@reddit.com>
justinmir
force-pushed
the
reduce-ec2-controller-api-calls
branch
from
76f21d2
to
ac631f9
Compare
MisterMX
reviewed
Apr 8, 2024
MisterMX
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
LGTM. Thanks for the contribution and the clarification @justinmir!
|
Successfully created backport PR #2033 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The EC2 instance controller synchronously makes several DescribeInstanceAttribut calls to the EC2 API and does not use the results. This slows down the reconcile time for a single observation.
This removes the API calls for attributes that are returned in
RunInstances.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested in staging/production in our fork. See drastic decrease in reconcile time for the ec2 instance resource.
Related to #2029