-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh Do mind moving the contribution guide into a separate file? This would unclutter the landing page. Edit: Move most of the content to custom-configuration.md and just have one link in the main readme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenh ! I believe we'll be able to move that guide to Terrajet once the pipeline abstraction is in place, right? since it'll hide away most of provider-specific stuff in generator/main.go
flow.
Yes, correct 👍 |
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
- Cherry-picked from crossplane-contrib/provider-jet-aws#123 by @turkenh - Extended the late-initialization section with an example use-case Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Cherry-picked from crossplane-contrib/provider-jet-aws#123 by @turkenh - Extended the late-initialization section with an example use-case Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Cherry-picked from crossplane-contrib/provider-jet-aws#123 by @turkenh - Extended the late-initialization section with an example use-case - Adjustments specific to provider-tf-azure Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Description of your changes
Resolves #118
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
N/A