Switch to shared gRPC server implementation #166
Conversation
ulucinar
force-pushed
the
fix-tj-261
branch
4 times, most recently
from
6a06414
to
b2fec9f
Compare
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
fix-tj-261
branch
3 times, most recently
from
f9b9d48
to
74d633c
Compare
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
| "gopkg.in/alecthomas/kingpin.v2" | ||
| kerrors "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/tools/leaderelection/resourcelock" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
|
|
||
| tjcontroller "github.com/crossplane/terrajet/pkg/controller" | ||
| "github.com/crossplane/terrajet/pkg/terraform" |
There was a problem hiding this comment.
I think the crossplane-runtime imports should be moved to this group.
| fmt.Sprintf(fmtEnvVar, envClientID, azureCreds[keyAzureClientID]), | ||
| fmt.Sprintf(fmtEnvVar, envClientSecret, azureCreds[keyAzureClientSecret]), | ||
| } | ||
| ps.Configuration[keyTenantID] = azureCreds[keyAzureTenantID] |
There was a problem hiding this comment.
Could you confirm that these are not printed in the error logs?
There was a problem hiding this comment.
Hi @muvaf,
I gave this a try by injecting an invalid key in Terraform provider configuration block. Here's what appears in managed resource status:
- message: 'observe failed: cannot run refresh: refresh failed: Extraneous JSON
object property: No argument or block type is named "non-existent".: File name:
main.tf.json'
reason: ReconcileError
status: "False"
type: SyncedAnd no relevant provider logs unless debug logging is enabled. If debug logs are enabled, then I think we are dumping Terraform output, which may, in theory, leak sensitive data. We can discuss this general issue in Terrajet.
| @@ -5,29 +5,32 @@ ARG ARCH | |||
| ARG TERRAFORM_VERSION | |||
| ARG TERRAFORM_PROVIDER_SOURCE | |||
| ARG TERRAFORM_PROVIDER_VERSION | |||
| ARG TINI_VERSION | |||
There was a problem hiding this comment.
Was this a remnant of something else?
There was a problem hiding this comment.
Yes, looks like it's no longer used.
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Description of your changes
Fixes crossplane/terrajet#261
Switches to the shared gRPC server implementation in
provider-jet-azure.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested using the corresponding Terrajet PR: crossplane/terrajet#267