Generate reference fields for the spec.initProvider of all resources #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #975
Fixes #994
This PR bumps the
upjet
to the commit4cb45f9104ac
with @sergenyalcin's changes addressing crossplane/upjet#307 and adds the referencer fields under tospec.initProvider
.This PR also bumps the crossplane-runtime to commit
d23a82b3a2f5
to consume crossplane/crossplane-runtime#623. The provider will use Server Side Apply (SSA) patch operations while updating the resolved cross-resource references. Thespec.forProvider.vpcConfig
ofCluster.eks
is converted into an associative list by injecting anindex
field and its SSA merge strategy is set tomap
so that the API server will be able to merge the list objects instead of replacing the whole list atomically, effective addressing #975. Please also see crossplane/upjet#308 for more context.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested the
Cluster.eks
resource via the uptest run: https://github.com/upbound/provider-aws/actions/runs/7342098403Also validated the race condition on the
spec.forProvider.vpcConfig[0].subnetIds
ofCluster.eks
is actually resolved with the P&T function v0.2.1 is used together with a custom build of theupbound/provider-aws
from this PR. The composition I've used is as follows: