Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(userdata): remove user_data and switch user_data_base64 to sensitive #1133

Closed
wants to merge 1 commit into from
Closed

fix(userdata): remove user_data and switch user_data_base64 to sensitive #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions apis/ec2/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/ec2/v1beta1/zz_instance_terraformed.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 1 addition & 14 deletions apis/ec2/v1beta1/zz_instance_types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions config/ec2/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ func Configure(p *config.Provider) {
},
}
config.MoveToStatus(r.TerraformResource, "security_groups")
r.TerraformResource.Schema["user_data_base64"].Sensitive = true
config.MoveToStatus(r.TerraformResource, "user_data")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this leak secrets that are in the user data?

})
p.AddResourceConfigurator("aws_eip", func(r *config.Resource) {
r.References["instance"] = config.Reference{
Expand Down
Loading
Loading