Add region parameter back to TF setup.Configuration #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
|
/test-examples="examples/sns/v1beta1/topic.yaml" |
erhancagirici
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
|
/test-examples="examples/kinesis/v1beta1/stream.yaml" |
mbbush
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
Thanks for the quick fix @erhancagirici! This LGTM. We just need to get it labeled with the backport label before merging.
|
Successfully created backport PR #1222 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1220
#1204 removed obsolete TF-CLI related configuration codepath and switched to native TF SDK configuration.
As a result of native SDK configuration,
terraform.Setup.Configurationwas no longer needed to configure TF AWS client and we ceaseHowever, several external name configurations which use external name templates, still rely on
terraform.Setup.Configurationmap to obtainregionvalue.The change adds the
regionparameter back toterraform.Setup.Configuration.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
With uptest, create resources that uses
.setup.configurationin their external name configs